Fix top pages comparison tooltip missing date labels#6221
Merged
Conversation
- The `/pages` endpoint was using `Map.merge` on a `Jason.OrderedObject`, which silently drops any merged keys during JSON encoding. Convert to a plain map first so date range labels are included in the response.
apata
reviewed
Apr 6, 2026
| json(conn, %{ | ||
| results: pages, | ||
| meta: Map.merge(meta, Stats.Breakdown.formatted_date_ranges(query)), | ||
| meta: Map.new(meta.values) |> Map.merge(Stats.Breakdown.formatted_date_ranges(query)), |
Contributor
There was a problem hiding this comment.
suggestion, non-blocking: I think we should add an assertion about pages.meta to an existing pages controller test, it doesn't seem to be covered at all right now.
apata
approved these changes
Apr 6, 2026
apata
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
/pagesendpoint was usingMap.mergeon aJason.OrderedObject, which silently drops any merged keys during JSON encoding. Convert to a plain map first so date range labels are included in the response.Before:
After:
Tests
Changelog
Documentation
Dark mode